[5.2] Fix JS CS missing trailing comma#44435
Merged
laoneo merged 2 commits intojoomla:5.2-devfrom Nov 11, 2024
Merged
Conversation
4 tasks
laoneo
reviewed
Nov 11, 2024
Member
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) fixes a small javascript code style error in file "tests/System/plugins/fs.mjs".
Here in the 5.2-dev branch, the linter does not complain about that, so the javascript-cs step passes.
But when doing my upmerge PR #44434 for 5.3-dev I've noticed that the javascript-cs step failed in Drone due to that CS error.
It was introduced with PR #44253 .
Testing Instructions
Check that the javascript-cs passes in Drone for this PR here..
Actual result BEFORE applying this Pull Request
The javascript-cs passes in Drone, but in the 5.3-dev branch it fails without this change.
Expected result AFTER applying this Pull Request
The javascript-cs passes in Drone.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed